-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for VSCode in distribution directory #383
base: master
Are you sure you want to change the base?
Conversation
Is it an upstream issue? |
It doesn't look like that. I don't think they even support this type of launch of unpacked VSCode. There are quite a few references to |
Do I understand the issue you're trying to solve correctly: normally vscode is shipped in one binary combined with electron, here I'm trying to run vscode from a folder and it all makes up for the difference? |
Yes, definitely true. |
Patching the lock file would most certainly fail with every release. I'd like to avoid the need of constantly fixing the patch. Perhaps appending to it would be better? |
I provided him with \n\n as a context for where to insert the changes, although I'm not sure it will work as intended. Should I then replace it with an append operation to the lock file? |
Hmm, it seems to work fine, still I think if you need to append the file, patch is not the best way of doing it. |
Some of the native VSCode modules depend on it being statically packaged. This PR should fix that.
The notable issue was the broken "Save as sudo" mode.