Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for VSCode in distribution directory #383

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Kawanaao
Copy link
Contributor

Some of the native VSCode modules depend on it being statically packaged. This PR should fix that.
The notable issue was the broken "Save as sudo" mode.

@Kawanaao Kawanaao marked this pull request as draft October 15, 2024 14:22
@Kawanaao Kawanaao marked this pull request as ready for review October 15, 2024 15:14
@PF4Public
Copy link
Owner

Is it an upstream issue?

@Kawanaao
Copy link
Contributor Author

Kawanaao commented Oct 15, 2024

Is it an upstream issue?

It doesn't look like that. I don't think they even support this type of launch of unpacked VSCode. There are quite a few references to process.execPath in the code, which work only in the case of packed Electron, including in the Git version of VSCode.

@PF4Public
Copy link
Owner

Do I understand the issue you're trying to solve correctly: normally vscode is shipped in one binary combined with electron, here I'm trying to run vscode from a folder and it all makes up for the difference?

@Kawanaao
Copy link
Contributor Author

Do I understand the issue you're trying to solve correctly: normally vscode is shipped in one binary combined with electron, here I'm trying to run vscode from a folder and it all makes up for the difference?

Yes, definitely true.

@PF4Public
Copy link
Owner

Patching the lock file would most certainly fail with every release. I'd like to avoid the need of constantly fixing the patch. Perhaps appending to it would be better?

@Kawanaao
Copy link
Contributor Author

Kawanaao commented Oct 18, 2024

Patching the lock file would most certainly fail with every release. I'd like to avoid the need of constantly fixing the patch. Perhaps appending to it would be better?

I provided him with \n\n as a context for where to insert the changes, although I'm not sure it will work as intended. Should I then replace it with an append operation to the lock file?

@Kawanaao Kawanaao marked this pull request as draft October 20, 2024 11:31
@PF4Public
Copy link
Owner

I provided him with \n\n as a context for where to insert the changes, although I'm not sure it will work as intended. Should I then replace it with an append operation to the lock file?

Hmm, it seems to work fine, still I think if you need to append the file, patch is not the best way of doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants