Upgrade Algolia package to V4 #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
added
Adapter: Algolia
alexander-schranz
force-pushed
the
feature/algolia-v4-upgrade
branch
from
61983ee to
67dec8c
Compare
| @@ -29,7 +29,7 @@ | |||
| "require": { | |||
| "php": "^8.1", | |||
| "schranz-search/seal": "^0.5", | |||
| "algolia/algoliasearch-client-php": "^3.3", | |||
| "algolia/algoliasearch-client-php": "^4.4", | |||
There was a problem hiding this comment.
version 4.4 supports again existIndex method
alexander-schranz
force-pushed
the
feature/algolia-v4-upgrade
branch
from
67dec8c to
8a124de
Compare
alexander-schranz
force-pushed
the
feature/algolia-v4-upgrade
branch
from
8a124de to
d4595a6
Compare
|
|
||
| $batchIndexingResponse = $searchIndex->saveObject( | ||
| $this->marshaller->marshall($index->fields, $document), | ||
| ['objectIDKey' => $identifierField->name], |
There was a problem hiding this comment.
this seems currently not supported in v4
| @@ -40,36 +40,45 @@ public function save(Index $index, array $document, array $options = []): TaskIn | |||
| { | |||
| $identifierField = $index->getIdentifierField(); | |||
|
|
|||
| $searchIndex = $this->client->initIndex($index->name); | |||
| $document = $this->marshaller->marshall($index->fields, $document); | |||
| $document['objectID'] = $document[$identifierField->name]; // TODO check objectIDKey instead see: https://github.com/algolia/algoliasearch-client-php/issues/738 | |||
There was a problem hiding this comment.
workaround for objectIDKey v4
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: https://www.algolia.com/doc/libraries/php/v4/upgrade/
Issues: