Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure identifiers are empty #465

Merged
merged 4 commits into from
Dec 27, 2024

Conversation

Toflar
Copy link
Member

@Toflar Toflar commented Dec 19, 2024

Fix and add missing parts of #460

@alexander-schranz
Copy link
Member

Looks like we missed to add this to the other ReindexCommands also?

@Toflar
Copy link
Member Author

Toflar commented Dec 19, 2024

I am not familiar with any of the other frameworks so I couldn't provide this.

@alexander-schranz
Copy link
Member

alexander-schranz commented Dec 19, 2024

@Toflar yii, mezzio is directly symfony/console so just a copy of that lines. Spiral, Laravel are symfony/console based so just a small adjustment about how the param is defined 😄

@alexander-schranz alexander-schranz added bug Something isn't working Integration: Symfony Symfony related issue Integration: Laravel Laravel related issue Integration: Spiral Spiral related issue Integration: Mezzio Mezzio related issue Integration: Yii Yii related issue labels Dec 19, 2024
@alexander-schranz alexander-schranz merged commit 45c93e6 into PHP-CMSIG:0.6 Dec 27, 2024
31 of 32 checks passed
alexander-schranz added a commit that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration: Laravel Laravel related issue Integration: Mezzio Mezzio related issue Integration: Spiral Spiral related issue Integration: Symfony Symfony related issue Integration: Yii Yii related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants