Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: PHP 8.4 has been released #228

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Nov 21, 2024

Proposed Changes

GH Actions: PHP 8.4 has been released

  • Builds against PHP 8.4 are no longer allowed to fail.
  • Add allowed to fail build against PHP 8.5.

Ref: https://www.php.net/releases/8.4/en.php

Tests/PHPCSVersions: update for new PHPCS releases

Refs:

@jrfnl
Copy link
Member Author

jrfnl commented Nov 21, 2024

P.S.: not sure what we can do about the failing security check (other than to drop support for certain old PHP/Composer versions as announced per #221).

@jrfnl jrfnl requested a review from Potherca November 21, 2024 23:13
@fredden
Copy link
Member

fredden commented Nov 27, 2024

P.S.: not sure what we can do about the failing security check (other than to drop support for certain old PHP/Composer versions as announced per #221).

If we use composer install --no-dev instead of composer install in that check, the test will pass.

Edit: I have created #229 to apply this change.

@jrfnl
Copy link
Member Author

jrfnl commented Jan 14, 2025

@Potherca Shall I merge this ? I mean, yes, the CI is failing, but that's unrelated to this PR and there are other PRs open which will fix that.

@Potherca
Copy link
Member

Merge at will.

@jrfnl jrfnl merged commit 725b0a3 into main Jan 14, 2025
98 of 102 checks passed
@jrfnl jrfnl deleted the feature/ghactions-update-for-php-8.4-release branch January 14, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants