fix #820 ShapeCollection::addShape with instanceof and @throws

PHPOffice · Nov 27, 2024 · 6a549ba · 6a549ba
1 parent b08eb11
commit 6a549ba
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/PhpPresentation/Traits/ShapeCollection.php b/src/PhpPresentation/Traits/ShapeCollection.php
@@ -20,6 +20,7 @@
 namespace PhpOffice\PhpPresentation\Traits;
 
 use PhpOffice\PhpPresentation\AbstractShape;
+use PhpOffice\PhpPresentation\ShapeContainerInterface;
 
 trait ShapeCollection
 {
@@ -76,12 +77,13 @@ public function setShapeCollection(array $shapeCollection = []): self
 
     /**
      * @return static
+     * @throws ShapeContainerAlreadyAssignedException
      */
     public function addShape(AbstractShape $shape)
     {
         $this->shapeCollection[] = $shape;
 
-        if (method_exists($shape, 'setContainer') && $shape->getContainer() === null) {
+        if ($this instanceof ShapeContainerInterface && $shape->getContainer() === null) {
             $shape->setContainer($this);
         }