#634 : Added ODFValidator

.github/workflows/validator.yml

@@ -0,0 +1,28 @@
+name: Validator
+on: [push, pull_request]
+jobs:
+  odf:
+    name: ODF Validator
+    runs-on: ubuntu-latest
+    steps:
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.4'
+          extensions: mbstring, intl, gd, xml, dom, json, fileinfo, curl, zip, iconv
+      - uses: actions/checkout@v2
+
+      - name: Composer Install
+        run: composer install --ansi --prefer-dist --no-interaction --no-progress
+
+      - name: Generate samples files
+        run: composer run samples
+
+      - name: Download ODFValidator
+        run: wget https://repo1.maven.org/maven2/org/odftoolkit/odfvalidator/0.12.0/odfvalidator-0.12.0-jar-with-dependencies.jar -O odfvalidator.jar
+
+      # https://odftoolkit.org/conformance/ODFValidator.html#what-is-checked
+      - name: Validate documents (ODF 1.2)
+        run: java -jar odfvalidator.jar -1.2 -e -r samples/results/ -x "^.*\/Sample_(04|22).*odp" 
+        ## 04 & 22 excluded
+        ## Cause : src/PhpPresentation/Writer/ODPresentation/Content.php::writeTableStyle

.gitignore

@@ -14,7 +14,7 @@ php-cs-fixer.phar
 .phpunit.result.cache
 composer.phar
 vendor
-/batch_CI.bat
+/odfvalidator.jar
 
 ### Samples
 /samples/Sample_00_Test.php

docs/changes/1.2.0.md

@@ -24,5 +24,6 @@
 - PowerPoint2007 Reader : Fixed loading of fonts by [@ag3202](https://github.com/ag3202) and [@Progi1984](https://github.com/Progi1984) in [#851](https://github.com/PHPOffice/PHPPresentation/pull/851)
 
 ## Miscellaneous
+- CI: Added ODFValidator by [@Progi1984](https://github.com/Progi1984) fixing [#678](https://github.com/PHPOffice/PHPWord/issues/678) in [#653](https://github.com/PHPOffice/PHPWord/pull/653)
 
 ## BC Breaks

phpstan.neon.dist

@@ -24,6 +24,8 @@ parameters:
     - '#^Parameter \#1 \$image of function imagesy expects GdImage, resource given\.#'
     - '#^Parameter \#1 \$image of function imagealphablending expects GdImage, resource given\.#'
     - '#^Parameter \#1 \$image of function imagesavealpha expects GdImage, resource given\.#'
+    # # PHP 8.0 & Attribute
+    - '#^Attribute class PHPUnit\\Framework\\Attributes\\DataProvider does not exist\.#'
 
   ## Remove after remove ArrayObject
   treatPhpDocTypesAsCertain: false

samples/Sample_03_Image.php

@@ -35,7 +35,8 @@
 
 // Add a file drawing (GIF) to the slide
 $shape = new Drawing\File();
-$shape->setName('Image File')
+$shape
+    ->setName('Image File')
     ->setDescription('Image File')
     ->setPath(__DIR__ . '/resources/phppowerpoint_logo.gif')
     ->setHeight(36)

samples/Sample_Header.php

@@ -108,14 +108,8 @@
 
 /**
  * Write documents.
- *
- * @param PhpPresentation $phpPresentation
- * @param string $filename
- * @param array $writers
- *
- * @return string
  */
-function write($phpPresentation, $filename, $writers)
+function write(PhpPresentation $phpPresentation, string $filename, array $writers): string
 {
     $result = '';