Skip to content

Conversation

@seanlynchwv
Copy link
Contributor

@seanlynchwv seanlynchwv commented Sep 8, 2025

Description

Adding custom SVGs now works

Fixed by #732 (comment)

Fixes # (issue)

#732

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@coveralls
Copy link

coveralls commented Sep 8, 2025

Coverage Status

coverage: 91.644% (+0.001%) from 91.643%
when pulling 6ae84da on seanlynchwv:fix/svg-error
into 7018fd8 on PHPOffice:master.

@seanlynchwv
Copy link
Contributor Author

Not sure why this is failing now, was passing earlier

@seanlynchwv seanlynchwv closed this Oct 6, 2025
@seanlynchwv seanlynchwv reopened this Oct 6, 2025
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanlynchwv Could you add an unit test please ?

- ODPresentation Reader : Read differents units for margin by [@Progi1984](https://github.com/Progi1984) fixing [#830](https://github.com/PHPOffice/PHPPresentation/pull/830) in [#847](https://github.com/PHPOffice/PHPPresentation/pull/847)
- PowerPoint2007 Reader : Fixed loading of fonts by [@ag3202](https://github.com/ag3202) and [@Progi1984](https://github.com/Progi1984) in [#851](https://github.com/PHPOffice/PHPPresentation/pull/851)
- PhpOffice\PhpPresentation\Style\TextStyle : Fixed typo for default indent by [@Progi1984](https://github.com/Progi1984) in [#857](https://github.com/PHPOffice/PHPPresentation/pull/857)
- Fixed adding custom SVGs by [@seanlynchwv](http://github.com/seanlynchwv) in [#881](https://github.com/PHPOffice/PHPPresentation/pull/881)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move to 1.3.0.md ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants