SL-816 Duplicate registrations caused by system error #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogoodrich
approved these changes
Jan 3, 2025
|
|
||
| -- person attributes | ||
| select person_attribute_type_id into @telephone from person_attribute_type where name = 'Telephone Number' ; | ||
| select person_attribute_type_id into @motherName from person_attribute_type where name = 'First Name of Mother' ; |
There was a problem hiding this comment.
Not a big deal, but do we connect these attributes in all our countries? I guess if not just needs to be null-safe.
| and d.reg_location <=> p.reg_location | ||
| and d.registration_date <=> p.registration_date | ||
| and date(d.registration_entry_date) <=> date(p.registration_entry_date) | ||
| and d.user_entered <=> p.user_entered; |
There was a problem hiding this comment.
I'm probably missing this, but why do we have to do a comparison on all the fields again? Doesn't the group part handle that?
| and exists | ||
| (select 1 from encounter e2 where e2.patient_id in | ||
| (select patient_id from temp_potential_dups_patient_ids d2 where d2.group_id = d.group_id) | ||
| and e2.encounter_type <> @regEncounterType |
There was a problem hiding this comment.
I'm probably missing this, but do you need to confirm that e2.patient is not equalt to e.patient? Or I guess it's the fact that the two clauses can never be both true for the same patient?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.