Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIB-155 Updates for NCD V2 and and added visits for check-in #57

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

tommyiversonj
Copy link
Contributor

No description provided.

@lnball lnball changed the title Updates for NCD V2 and and added visits for check-in LIB-155 Updates for NCD V2 and and added visits for check-in Jul 25, 2022
Copy link
Member

@lnball lnball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tommyiversonj Nice work but requires a little cleanup. See comments

@@ -87,15 +87,14 @@

<p class="left">
<obs conceptId="PIH:REASON FOR VISIT" id="typeOfVisit"
answerConceptIds="PIH:OUTPATIENT CONSULTATION,PIH:ANC VISIT,PIH:MENTAL HEALTH SERVICES,PIH:INPATIENT HOSPITALIZATION,PIH:EMERGENCY VISIT,PIH:NCD Program,PIH:General Surgery,PIH:Obstetrics-Gynecology,PIH:Opthalmology,PIH:MALNUTRITION PROGRAM,PIH:Immunization visit,PIH:Labor and delivery visit,PIH:POSTNATAL VISIT,PIH:ART VISIT,PIH:PMTCT VISIT,PIH:FAMILY PLANNING SERVICES,PIH:OTHER NON-CODED"
answerLabels="Outpatient,ANC,Mental Health Clinic,Inpatient,Emergency,NCD Clinic,General Surgery,Obstetrics/Gynecology,Eye Clinic,Malnutrition,EPI,Labor and Delivery,Postnatal,ART Clinic,PMTCT,Family Planning,Other"
answerConceptIds="PIH:OUTPATIENT CONSULTATION,PIH:ANC VISIT,PIH:MENTAL HEALTH SERVICES,PIH:INPATIENT HOSPITALIZATION,PIH:EMERGENCY VISIT,PIH:NCD Program,PIH:General Surgery,PIH:Obstetrics-Gynecology,PIH:Opthalmology,PIH:MALNUTRITION PROGRAM,PIH:Immunization visit,PIH:Labor and delivery visit,PIH:POSTNATAL VISIT,PIH:ART VISIT,PIH:PMTCT VISIT,PIH:FAMILY PLANNING SERVICES,PIH:TB VISIT,PIH:HOSPITAL PEDIATRICS,PIH:Medical ward,PIH:OTHER NON-CODED,"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing comma.

@@ -59,7 +59,7 @@
</fieldset>
</div>
</div>

c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 'c'

@@ -72,8 +72,8 @@

<p class="left">
<obs conceptId="PIH:REASON FOR VISIT" id="typeOfVisit"
answerConceptIds="PIH:OUTPATIENT CONSULTATION,PIH:ANC VISIT,PIH:MENTAL HEALTH SERVICES,PIH:INPATIENT HOSPITALIZATION,PIH:EMERGENCY VISIT,PIH:NCD Program,PIH:General Surgery,PIH:Obstetrics-Gynecology,PIH:Opthalmology,PIH:MALNUTRITION PROGRAM,PIH:Immunization visit,PIH:Labor and delivery visit,PIH:POSTNATAL VISIT,PIH:ART VISIT,PIH:PMTCT VISIT,PIH:FAMILY PLANNING SERVICES,PIH:OTHER NON-CODED"
answerLabels="Outpatient,ANC,Mental Health Clinic,Inpatient,Emergency,NCD Clinic,General Surgery,Obstetrics/Gynecology,Eye Clinic,Malnutrition,EPI,Labor and Delivery,Postnatal,ART Clinic,PMTCT,Family Planning,Other"
answerConceptIds="PIH:OUTPATIENT CONSULTATION,PIH:ANC VISIT,PIH:MENTAL HEALTH SERVICES,PIH:INPATIENT HOSPITALIZATION,PIH:EMERGENCY VISIT,PIH:NCD Program,PIH:General Surgery,PIH:Obstetrics-Gynecology,PIH:Opthalmology,PIH:MALNUTRITION PROGRAM,PIH:Immunization visit,PIH:Labor and delivery visit,PIH:POSTNATAL VISIT,PIH:ART VISIT,PIH:PMTCT VISIT,PIH:FAMILY PLANNING SERVICES,PIH:TB VISIT,PIH:HOSPITAL PEDIATRICS,PIH:Medical ward,PIH:OTHER NON-CODED,"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. remove trailing comma

<obs conceptId="PIH:Type of Diabetes Diagnosis" style="radio"
answerSeparator=""
answerConceptIds="CIEL:142474, CIEL:165207"
answerLabels="Type 1 diabete, Type 2 diabete"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this 'diabetes'?

style="checkbox"/>
</span>
</includeIf>
answerLabels="Pale, Pink"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order doesn't match the answerConceptIds (normal, pale) -- not pale and pink. Not sure if you need to change the answerConceptIds or labels.

<label>
Summary of clinical impression:
</label>
<obs id="diagnosis summary" conceptId="CIEL:160632" answerConceptId="CIEL:159395" style="textarea"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For text, there's no answerConceptId. I think you want to have conceptId="CIEL:159395" and remove the answerConceptId.

Copy link
Member

@mogoodrich mogoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tommyiversonj ! I'll defer to @lnball 's comments on this one.

Copy link
Member

@lnball lnball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

@lnball lnball merged commit e31ea41 into master Aug 1, 2022
@lnball lnball deleted the LIB-155 branch August 1, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants