Improve CoinGecko stability, add attribution #188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This simple PR improves the stability of our CoinGecko integration:
Currency
even if CoinGecko is unavailable.Previously, even a single CoinGecko call failing would still display a generic "Uncaught Network Error" for the user, CoinGecko calls sometimes randomly fail, so this was causing users that kept MPW open for long periods of time, to randomly return to errors on their app, this should be less now that CoinGecko errors are handled perfectly.
Additionally, the PR adds i18n'd CoinGecko attribution, which is required by their documentation terms.
Testing
This PR is fairly behind-the-scenes, so the best tests a user can do, is to simply check that their currency (USD, GBP, etc) is loading correctly, displaying correctly in all areas, and that the Settings show the currency options and CoinGecko attribution.
For folks that are confident in messing with the Browser Developer Console, however, you can follow this to thoroughly test the PR:
If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!