-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Mnemonic handling + UX, Add Advanced Mode #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tack: tested on linux different inputs:
1- valid seedphrase passed
2- non-valid seedphrase was blocked
3- valid seedphrase with white spaces was stripped as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR works really well, i tried inserting a number of spaces in various places of the seed phrase and they all got removed as expected.
I've left some minors nitpicks
Co-authored-by: Duddino <[email protected]>
Co-authored-by: Duddino <[email protected]>
Co-authored-by: Duddino <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Abstract
This PR largely improves Seed Phrase UX, by:
The UX is simplified by removing the below functionality, outside of "Advanced Mode":
"Advanced Mode" is an off-by-default, session persisted mode in which MPW's functionality is simplified, to improve the experience for less knowledgeable users that are prone to losing funds from accidental mistakes, such as mixing up BIP39 Passphrases with their MPW Password, hitting "Confirm" when MPW warns of Seed Phrase typos, etc.
In future PRs, Advanced Mode will be leveraged to also hide features such as "VanityGen", and any other non-primary features of MPW, to simplify the app as much as possible for the average user.
This feature allows for both New and Advanced users to benefit from MPW, without any drawbacks, both communities can eat their cake, rather than removing "complex" features in the name of simplicity, but denying advanced users their tools.
Testing
This PR can be tested in various ways, I'll outline a bunch of them below, each with their own "testing flow", feel free to try variations of these to maximise our testing reach!
1: Test Creating a new wallet in Normal and Advanced mode
2: Test importing a Seed Phrase in various ways, in Normal or Advanced Mode
Now, try importing it in various ways, such as:
If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!