Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalise translations for v1.2.0 #193

Merged
merged 15 commits into from
Sep 10, 2023
Merged

Finalise translations for v1.2.0 #193

merged 15 commits into from
Sep 10, 2023

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Sep 5, 2023

Abstract

This is our monthly PR to bring MPW's translation files back to full i18n parity!

PR will remain as a draft until either all translations are complete, or we're less than 12 hours away from launch.


Testing

This PR is best suited for multi-lingual QC members, as it requires checking other languages for their support on MPW.

To test this PR, simply:

  • Ensure all areas of MPW are translated. (Barring the soon-to-be-redesigned Masternode Dashboard).

If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!


@JSKitty JSKitty added the Enhancement New feature or request label Sep 5, 2023
@JSKitty JSKitty self-assigned this Sep 5, 2023
@JSKitty
Copy link
Member Author

JSKitty commented Sep 5, 2023

Note: prettier will be ran before merge, to make it easier for translators to work without dealing with linting.

@JSKitty JSKitty changed the title [WIP] Finalise translations for v1.2.0 Finalise translations for v1.2.0 Sep 8, 2023
@JSKitty JSKitty marked this pull request as ready for review September 8, 2023 16:26
@JSKitty JSKitty added Awaiting Review This PR and/or issue is awaiting reviews before continuing. Review Reward: 10 PIV Reviewers of this Pull Request will receive a 10 PIV reward labels Sep 8, 2023
@JSKitty JSKitty merged commit dbb6e69 into master Sep 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Review This PR and/or issue is awaiting reviews before continuing. Enhancement New feature or request Review Reward: 10 PIV Reviewers of this Pull Request will receive a 10 PIV reward
Projects
Development

Successfully merging this pull request may close these issues.

1 participant