Solve activity spam #209
Merged
Solve activity spam #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duddino
added
Bug
JSKitty
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Going to give a tACK 81bbf15
Minor nit: I think the reason I allowed syncing history between blocks, is because Blockbook has this little 'delay' or 'cache' of block heights: I'm sure I tested previously that the history updates quicker than the block count on Blockbook's APIs, so this PR slightly slows down the activity and balance 'reactivity', my TX took 2 minutes before showing, when it usually should take 1 minute (60s).
Liquid369
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Activity was being synced multiple times per block. This is because
Network::getBlockCountresolves the promise immediately (This may have changed, i'm not sure).Added a new event, 'new-block', and moved the console.log and the activityUpdate there
Example of the amount of times Activity::update was called on master, using the latest state of the art profiling tools
Testing