Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jest #216

Merged
merged 6 commits into from
Oct 13, 2023
Merged

jest #216

merged 6 commits into from
Oct 13, 2023

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Sep 26, 2023 •
edited
Loading

Abstract

Adds the jest framework for unit tests.
Implemented masterkey tests to assert that addresses are generated correctly

Testing

Ironically, not much testing is required.

  • (Developers only) Run npm test and assert that tests pass
  • General basic functionality testing

@Duddino Duddino added Documentation Improvements or additions to documentation Enhancement New feature or request labels Sep 26, 2023
@Duddino Duddino requested a review from JSKitty September 26, 2023 13:32
@netlify
Copy link

netlify bot commented Sep 26, 2023 •
edited
Loading

✅ Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 8fb2e3b
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/65294253bea2b80009a0ab4b
😎 Deploy Preview https://deploy-preview-216--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Duddino Duddino marked this pull request as ready for review September 29, 2023 08:41
panleone
panleone previously approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 08f0836
I guess the babel is needed in order to convert from javascript ES6 to the older version used by jest. I will surely help adding unit test coverage in following PRs

Liquid369
Liquid369 approved these changes Oct 13, 2023
View reviewed changes
Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 8fb2e3b

JSKitty
JSKitty approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@JSKitty JSKitty merged commit 65dc91c into PIVX-Labs:master Oct 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liquid369 Liquid369 Liquid369 approved these changes

@JSKitty JSKitty JSKitty approved these changes

@panleone panleone panleone left review comments

Assignees

@Duddino Duddino

Labels
Documentation Improvements or additions to documentation Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Duddino @panleone @JSKitty @Liquid369