Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ledger udev error #224

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Fix ledger udev error #224

merged 3 commits into from
Oct 10, 2023

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Oct 9, 2023

Abstract

This PR just makes the check case insensitive.
The error was much more descriptive than the former undefined, but the intended message wasn't being displayed

Testing

  • Try to access the ledger without proper udev rules

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit feaf3c3
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/6523e346aa50af00087d3e82
😎 Deploy Preview https://deploy-preview-224--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

@JSKitty
Copy link
Member

JSKitty commented Oct 10, 2023

Merging on one review to ensure this is included in v1.3.0 - change is small enough to allow for it.

@JSKitty JSKitty merged commit 0481fb9 into PIVX-Labs:master Oct 10, 2023
4 checks passed
JSKitty pushed a commit that referenced this pull request Oct 10, 2023
* Fix ledger error

* lowercase

* Remove console.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants