Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer Activity date format #465

Merged
merged 9 commits into from
Nov 19, 2024
Merged

Nicer Activity date format #465

merged 9 commits into from
Nov 19, 2024

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Nov 17, 2024

Abstract

This PR simply swaps the Activity's date format from using DD/MM/YY to Month Day / Day Month (depending on locale), which is easier to read, adds space on mobile, and only renders the year if the Tx was created in a previous year.

image


Testing

To test this PR, it's suggested to attempt these user flows, or variations of these:

  • Check that Txs older than 24h use the new Date format.

If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!


@JSKitty JSKitty added the Enhancement New feature or request label Nov 17, 2024
@JSKitty JSKitty self-assigned this Nov 17, 2024
Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 16c31d7
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/673c7a2d3d4d2600083a6132
😎 Deploy Preview https://deploy-preview-465--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also show the year if a transaction is 1 year old.
Also I think the e2e test should be updated (idk why it is not failing)?

@JSKitty
Copy link
Member Author

JSKitty commented Nov 18, 2024

I think we should also show the year if a transaction is 1 year old. Also I think the e2e test should be updated (idk why it is not failing)?

Simplified the date selection logic and also added shorthand Years for Txs in previous years.
image

scripts/dashboard/Activity.vue Outdated Show resolved Hide resolved
scripts/dashboard/Activity.vue Outdated Show resolved Hide resolved
Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 16c31d7

@panleone panleone merged commit d60c69b into master Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants