Fix 455 #473
Merged
Fix 455 #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JSKitty
previously approved these changes
Nov 21, 2024
There was a problem hiding this comment.
tACK 0c423c1
- Created + Encrypted a new wallet.
- Fully synced Shield and switched to Private Mode.
- Deleted wallet and imported a Legacy Wallet.
- Performed a Transparent Tx without issue.
Looking good. Just e2e tests do not seem happy in GitHub Actions.
Duddino
added a commit
to Duddino/MyPIVXWallet
that referenced
this pull request
Dec 2, 2024
This is a copy of 27b17a9 with the cypress playback removed. Those had to be removed, due to their big sizes. * Fix private mode on non-private wallets * Add e2e tests * Fix eslint warning * Commit this * Now it works please --------- Co-authored-by: Alessandro Rezzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Fix #455 and add e2e tests
Testing
(You can skip this, there is an e2e test that does exaclty this)