Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for getHistoricalTxs() #477

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

panleone
Copy link
Member

Abstract

Add integration tests for the wallet method getHistoricalTxs(). The following things are tested:

  • HistoricalTxs are correctly updated when a new block is received
  • When a transaction is created, it is added as pending HistoricalTx
  • When the corresponding block is mined, pending transaction are marked as non-pending
  • Old non-pending HistoricalTxs don't change when a new block is received

Note: this tests are NOT testing that the final Activity displayed is correct.


@panleone panleone added the Test Addition of unit or functional test label Nov 23, 2024
@panleone panleone requested review from JSKitty and Duddino November 23, 2024 09:16
@panleone panleone self-assigned this Nov 23, 2024
Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit a73cf26
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/67446e566f065600081493c3
😎 Deploy Preview https://deploy-preview-477--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@Duddino Duddino merged commit 648377a into PIVX-Labs:master Nov 26, 2024
6 checks passed
Duddino pushed a commit to Duddino/MyPIVXWallet that referenced this pull request Dec 2, 2024
* test: Add integration test for historical txs

* Add spacing to tests
@panleone panleone deleted the wallet_histtx_test branch December 8, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Addition of unit or functional test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants