Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Wallet fixes #497

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Export Wallet fixes #497

wants to merge 5 commits into from

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Dec 12, 2024

Abstract

This small PR has various fixes for our Export Wallet feature:

  • The file type in the File Export button is now correct (.json instead of .csv).
  • The file export icon now renders correctly; previously, it was invisible.
  • The private key text now word-wraps symmetrically; nicer on the eyes, uses less height, and easier to copy/paste.

Testing

To test this PR, it's suggested to attempt these user flows, or variations of these:

  • Check that the 'file export' button icon is displayed.
  • Check that the plaintext export data word-wraps symmetrically and evenly.
  • Check that the file export's file type is the correct type (json).

If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!


@JSKitty JSKitty added the Bug This is either a bugfix (PR) or a bug (issue). label Dec 12, 2024
@JSKitty JSKitty self-assigned this Dec 12, 2024
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 0ba77c5
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/675c6baf82506d000891ee3a
😎 Deploy Preview https://deploy-preview-497--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant