Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delegate change when using ledger #520

Merged

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Jan 9, 2025

Abstract

Don't delegate change when using ledger, since ledger can't delegate by itself.
Closes #481

Testing

  • Send a cold UTXO to a ledger wallet
  • Try to unstake part of it
  • Assert that the whole amount is unstaked

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 2c70b2a
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/679a2f39176a07000938466a
😎 Deploy Preview https://deploy-preview-520--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2c70b2a

Simple enough change, given Ledger can't delegate in the first place, hah.

Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2c70b2a

@Duddino Duddino merged commit 7280e9a into PIVX-Labs:master Feb 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ledger unstaking fails when there is a cold staked UTXO change
3 participants