Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): 修复当跳往扩展页面的导航项位于已有导航项的下面时,此扩展页面的导航结构不显示的问题 #1393

Merged

Conversation

ddadaal
Copy link
Member

@ddadaal ddadaal commented Aug 11, 2024

img_v3_02dl_5906595d-858e-42f4-a7bb-b244b6ce3ceg

主要逻辑:

  1. 如果一个导航项的任何一个子项被选中,那么一个导航项也会被选中,而即使此导航项本身的path和当前path没有关系
  2. 大屏幕的侧边栏显示的子导航为第一个被选中的一级导航项的子项

@ddadaal ddadaal requested a review from piccaSun August 11, 2024 02:50
@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Aug 11, 2024
Copy link

changeset-bot bot commented Aug 11, 2024

🦋 Changeset detected

Latest commit: c2c39e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@scow/lib-web Patch
@scow/ai Patch
@scow/mis-web Patch
@scow/portal-web Patch
@scow/auth Patch
@scow/gateway Patch
@scow/mis-server Patch
@scow/portal-server Patch
@scow/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@piccaSun
Copy link
Contributor

piccaSun commented Aug 12, 2024

@ddadaal 有一个小问题是下列配置项中的name会写入路由

uiExtension:
  -
    # 您的UI扩展页部署URL。
    name: EXT-TEST
    url: http://localhost:端口号

如果这个name配置为中文或者需要转义的特殊字符,是无法获取activeKeys的
aaa
bbb
ccc

但是现在导航项位于已有导航项下的情况,其实可以不配置name,直接更改扩展页的标题来进行页面标题的显示 #1389
所以请看看这个要不要修改,还是修改一下文档中关于name配置的说明?

@ddadaal
Copy link
Member Author

ddadaal commented Aug 12, 2024

已修复当extensionName为需要encode的字符的时候此修复不生效的问题

image

@piccaSun piccaSun added the Code-Approved Code Review approved label Aug 12, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot removed the Code-Approved Code Review approved label Aug 12, 2024
@piccaSun piccaSun added Code-Approved Code Review approved and removed Code-ReviewRequested Code Review Requested labels Aug 12, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot added the ReadyForMerge Ready for merge label Aug 12, 2024
@ddadaal ddadaal merged commit d3de802 into master Aug 12, 2024
9 checks passed
@ddadaal ddadaal deleted the show-navbar-struct-for-extension-navitems-under-existing-items branch August 12, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-Approved Code Review approved ReadyForMerge Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants