feat: Initializer support for struct member fields #1478
+1,577
−234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where some global variable initializer such as
```
TYPE StructA:
STRUCT
foo: REF_TO DINT;
bar: REF_TO DINT;
END_STRUCT
END_TYPE
VAR_GLOBAL
globalFoo: DINT;
globalVar: StructA := (foo := REF(globalFoo), bar := REF(globalFoo));
// ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^
END_VAR
```
would return incorrectly return a diagnostic claiming `REF(globalFoo)` can not
be assigned to `foo` because the resolver returned type `StructA` rather than
`StructA.foo`.
…mber fields The information about the left hand side was missing when indexing struct member fields for the const-evaluator. As a result such initializer would not be visible in the init lowering stage.
Struct initializers in their type definition as well as declarations in the VAR_GLOBAL block are now correctly initialized in their `__init` functions. A handful of tests are still failing however. The commit also lacks tests, most importantly lit tests.
volsa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for struct initializers of complex data types, with a main focus on polymorphism. Specifically the following use-cases are now supported:
Adds support for initalizers in struct member variables, with a main focus on creating virtual tables for polymorphism. Specifically the following use-cases are now supported:
These initializer can also be nested structs such that
a := (b := (c := REF(d))is valid. Generally this is achieved by adding fully-qualified variable assignments to the__init*function, i.e. the given example would internally resolve toself.a.b.c := REF(d).