Skip to content

Conversation

ghaith
Copy link
Collaborator

@ghaith ghaith commented Sep 16, 2025

Fix clippy complaints that we will encounter in the new rust version to prepare for the update.

@ghaith ghaith requested review from volsa and mhasel September 16, 2025 06:42
@ghaith ghaith requested a review from volsa September 19, 2025 15:13
@ghaith ghaith marked this pull request as ready for review September 19, 2025 15:14
Copy link
Member

@volsa volsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100 bucks I'll see a if-let-chain (stabilized with 1.88) within the next ~5 PRs 😄

Edit: Actually, for that we would need to update the rust edition to 2024. Shall we do that here as well?

@ghaith
Copy link
Collaborator Author

ghaith commented Sep 22, 2025

i'll do it in the next step, we can't build at the moment because of clippy

@ghaith ghaith merged commit 7b80dee into master Sep 22, 2025
23 checks passed
@ghaith ghaith deleted the rust_update branch September 22, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants