Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature burden sample ids #45

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Feature burden sample ids #45

merged 6 commits into from
Dec 15, 2023

Conversation

meyerkm
Copy link
Collaborator

@meyerkm meyerkm commented Dec 15, 2023

What

This PR creates an additional zarr file output of the sample ids during the compute burdens execution. The sample ids correspond to the samples of which of the burdens were calculated for.
Sample ids within the zarr file can be used for additional association testing analysis, as desired.

Testing

  1. Run pytest
  2. Run the snakemake pipeline on the example data
  3. Run association testing pipeline on real data to verify the new zarr file is created correctly

@meyerkm meyerkm requested review from endast and bfclarke December 15, 2023 13:23
@meyerkm meyerkm changed the title Burden sample ids Feature burden sample ids Dec 15, 2023
Copy link
Contributor

@bfclarke bfclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@bfclarke bfclarke merged commit 67c70ae into main Dec 15, 2023
@meyerkm meyerkm deleted the burden-sample-ids branch May 6, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants