Skip to content

Commit

Permalink
Merge pull request #89 from kinow/running-tests
Browse files Browse the repository at this point in the history
Avoid creating file in user desktop, fix typos and tests location
  • Loading branch information
illusional authored Sep 1, 2021
2 parents ea26d97 + 0f2fc7b commit 2433543
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 3 additions & 1 deletion janis_core/tests/test_translation_wdl.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import unittest
from tempfile import TemporaryDirectory
from typing import Optional

from janis_core.deps import wdlgen
Expand Down Expand Up @@ -1600,7 +1601,8 @@ def test_file_int_fail(self):

class TestForEachSelectors(unittest.TestCase):
def test_minimal(self):
TestForEach().translate("wdl", to_disk=True, export_path="~/Desktop/tmp")
with TemporaryDirectory() as tmpdir:
TestForEach().translate("wdl", to_disk=True, export_path=tmpdir)
w, _ = WdlTranslator.translate_workflow(TestForEach())
expected = """\
version development
Expand Down
4 changes: 2 additions & 2 deletions janis_core/translations/translationbase.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def __str__(cls):

class TranslatorBase(ABC):
"""
So you're thinking about adding a new tWranslation :)
So you're thinking about adding a new translation :)
This class will hopefully give you a pretty good indication
on what's required to add a new translation, however what I
Expand All @@ -88,7 +88,7 @@ class TranslatorBase(ABC):
and then write unit tests to cover each component of the translation
and then an integration test of the whole translation on the related workflows.
You can find these in /janis/tests/test_translation_*.py)
You can find these in /janis_core/tests/test_translation_*.py)
"""

__metaclass__ = TranslatorMeta
Expand Down
2 changes: 1 addition & 1 deletion requirements/documentation.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
-r base.txt
Sphinx==1.8.2
sphinx-autobuild==0.7.1
tabulate==0.8.2
tabulate

0 comments on commit 2433543

Please sign in to comment.