[스프린트 4] 강수민 - 팀 공지사항 업데이트 기능 API 구현 #48
Merged
+108
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddglackrp
reviewed
Dec 19, 2024
|
|
||
| if(!member.getUuid().equals(team.getTeamManager().getUuid())) { | ||
| throw new TeamManagerInvalidException(); | ||
| } |
There was a problem hiding this comment.
객체 내부에 검증 관련 method가 있으면 좋을 것 같습니다.
그리고 주체는 Team 이 되면 좋을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ 변경 요약
팀 공지사항 필드를 추가하고, 팀 공지사항 업데이트 API를 구현했습니다.
🔍 작업 내용
📌 관련된 이슈
Resolves #21
📢 기타
...
📋 RCA 룰
r: 꼭 반영해 주세요. 적극적으로 고려해 주세요. (Request changes)
c: 웬만하면 반영해 주세요. (Comment)
a: 반영해도 좋고 넘어가도 좋습니다. 그냥 사소한 의견입니다. (Approve)