Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the noImp decorator in enclosure builder #1008

Merged
merged 2 commits into from
May 14, 2024

Conversation

svevang
Copy link
Member

@svevang svevang commented Apr 29, 2024

Delegated delivery:

Copy link
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a test, but otherwise looks good to me!

@@ -62,8 +62,8 @@
end

describe "#enclosure_url" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh - looks like there's a dup test case just above this?

@svevang svevang merged commit b5cb861 into main May 14, 2024
3 checks passed
@svevang svevang deleted the cdn-impressions-for-publisher branch May 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants