Quiet job continuation #1133
Open
Quiet job continuation #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kookster
reviewed
Nov 6, 2024
app/jobs/publish_feed_job.rb
Outdated
| when "rss" then [:error_rss!, :warn, true] | ||
| when "apple_timeout" | ||
| level = apple_timeout_log_level(error) | ||
| [:retry!, level, level == :fatal || level == :error] |
There was a problem hiding this comment.
I might refactor to %i[error fatal].include?(level), but this makes sense as the place to decide to raise the error or not.
Another question that's not a request for change - does it feel like this is info I wish was on the error somehow, like how the error has a log level, can it also have a raise or not? maybe that is not a good responsibility for the error, idk.
There was a problem hiding this comment.
Re: clarity, Good point!
Re: error interface responsibility. Hrm, yes, I see what you're getting at. In essence, we're already responding to the error as the controlling parameter here, so why not push that should_raise? responsibility up to the error class itself...
kookster
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1116 and #1122
Quietly retry apple jobs and send alerts (error+fatal log lines) in the case of long waits