Switch to svelte-codemirror-editor
#160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lishaduck
force-pushed
the
switch-to-svelte-codemirror-editor
branch
from
ce8772e to
0cf1994
Compare
Also drop the dependency on codemirror, which just provides presets. This restores the ability to programmatically set the value from Svelte. You could only set the initial value before, but that's not very Svelte.
lishaduck
force-pushed
the
switch-to-svelte-codemirror-editor
branch
from
0cf1994 to
58d6bac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the ability to programmatically set the value from Svelte.
You could only set the initial value before, but that's not very Svelte.
Interestingly, I didn't need to disable
optimizeDeps, perhaps I should send a PR over to scm to update their docs (EDIT: I did file one, touchifyapp/svelte-codemirror-editor#38).