-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional tests, approximate distributions from raw data #22
Conversation
@john-p-ryan In this PR I'm trying to move away from the binning of data by income group and rather approximate the earnings distribution and the MTR schedule directly from the raw data. This helps avoid zero weight bins. The approximation of the population distribution seems to go quite well (although it doesn't exactly match the theoretical moments at all points in the distribution, it is close). But the approximation of the MTR schedule has proven more challenging. Fitting a spline function to the whole distribution often takes several minutes and it's seems tricky to get the smoothing parameter just right - either theirs too much noise or important curvature in the MTR schedule is missed. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 90.24% 81.81% -8.43%
==========================================
Files 3 3
Lines 123 88 -35
==========================================
- Hits 111 72 -39
- Misses 12 16 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This PR adds some additional unit test, including one to compare the computational solution to an analytical one.
It also removes the binning of the raw data by income group and rather uses the raw data directly to approximate the income distribution (which should resolve Issue #16).