-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Citations page in addition to references page #717
Comments
@rickecon I hadn't even noticed that the references and citations were not showing up! I'm glad to see the references are fixed.
Right, this is why
We do want it to be scraped, which his why it is important this file resides in the top-level directory, since different repos put their docs in different directory structures. That makes it easy for the scaper to find the file. This doesn't impact it's compilation in the Jupyter-Book. |
@jdebacker. My Juypter Book version is 0.10.0. I wonder if my need in PR #683 to add the |
I just pinned the Jupyter Book environment to v. 0.9.1 in PR #683. And now the citations page compiles fine. I wonder if it will work in version 0.10.0 if we add another reference line to the |
Yes, sounds like we missed some updates for JB v 0.10.0...
I think trying this would be good. I'd like to avoid anymore hard pins. They can cause conflicts with other dependencies. |
I changed the Fix attempt 1
Fix attempt 2, copying citations.md to same directory as OGUSA_references.bib
I think we should move forward with this PR #683 as it is, and work to fix the citations page in a future PR, leaving this issue thread open until fixed. |
I have verified that our previous approach compiles the References and Citations pages and all in-text references correctly for Jupyter Book v. 0.9.1, but it breaks for anything higher than v. 0.10.0. The Jupyter Book changelog for version 0.10.0 says:
My guess is that our previous approach of putting the |
I tried updating the
Fix attempt 2, copying citations.md to same directory as OGUSA_references.bib, also adjusting reference in citations.md
|
@jdebacker . I don't know what I did, but the Jupyter Book v. 0.10.1 is now compiling the Citations page, with |
This is a hard problem to solve with our documentation. We use Jupyter Book to create the OG-USA documentation, which is available at https://pslmodels.github.io/OG-USA/ and the source code of which is in the OG-USA/docs/book/ directory of the OG-USA repository.
Some past PR broke the compilation of any of the in-text citation references (see broken reference here) or any compilation of the references in the References section or in the Citations section of the documentation. These issues were discussed in Issue #613, and partially solved in subsequent PRs (PR #634 and PR #664). However, it is not clear if the Citations page compilation worked after PR #664 or if it was subsequently broken.
The following is the behavior that I think we want. And I think this will not be straightforward to execute.
OGUSA_references.bib
file. PR Big documentation update #683 fixes this. However, PR Big documentation update #683 does not currently address the following two issues.citations.bib
file. We want this page to compile a reference line for every reference incitations.bib
, independent of overlap withOGUSA_references.bib
and independent of whether anycitations.bib
references are cited in the text.citations.bib
file to be able to be scraped the the PSL Models organization for compilation of OG-USA specific references on the PSL Models web page. I think the natural location forcitations.bib
is in the same directory as the main BibTeX fileOGUSA_references.bib
.citations.bib
is currently at the main level of the OG-USA repo (OG-USA/citations.bib
).cc: @jdebacker @MaxGhenis
The text was updated successfully, but these errors were encountered: