-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big documentation update #683
Conversation
My last commit finished a big update for all the documentation up through the steady-state equilibrium section of |
@jdebacker said:
I fixed the typo in the first section of the "Calculating UBI" section, and I rewrote the last paragraph of the "UBI specification not adjusted for economic growth" section to be two paragraphs with a new equation in between, plus a new footnote. They are the following: |
@jdebacker said:
I don't know about this. Conceptually it is always nice to have OG-USA read parameters from Tax-Calculator or any other model. But:
My inclination is to keep these separate for now. But it would be straightforward to harmonize them in the future. @MaxGhenis signed off on the OG-USA parameters when I set them up. |
@jdebacker . I think I have addressed all your questions in the discussion above. Let me know what else you would like me to change for this to be merged. Thanks for the long review. |
Yeah I don't think we can avoid the confusion here on parameters, but separate names from the taxcalc parameters seems like the right call IMO. Will the UBI go in the |
@MaxGhenis said:
I haven't crossed that bridge yet. But I don't think it makes sense to put them in the Tax-Calculator parameters since they will not be Tax-Calculator parameters. |
@rickecon Said:
The use case would be the same as with taxes: one wants to get a detailed static revenue estimate and distributional analysis and so simulates a UBI in Tax-Calculator. Then one further wants to find the economic impacts of this plan and so runs the UBI program through OG-USA. By mapping parameters from Tax-Calculator into OG-USA, the user only needs to specify the parameters one time and it ensures consistency.
This is a good point - we could do that. But we are starting from scratch now, so we can avoid having to do work later if we want.
Yes, but we could (in principle) add one more parameter for UBI for 18-20 year olds to OG-USA and a UBI for 65+ to Tax-Calculator. Seems like the latter would be a good addition to Tax-Calculator - kind of surprised it's not there. The UBI for 18-20 year olds in OG-USA could be tough to calibrate since they aren't economically active in the model at that age, but in the data there maybe many of that age in their own households (not dependents of their parents). cc @MaxGhenis
|
@MaxGhenis. Given your esteemed position as the head of the UBI Center, what parameters should we have in both Tax-Calculator and OG-USA? |
Adding UBI_65 is blocked by a taxdata bug, see PSLmodels/Tax-Calculator#2469. I think taxcalc split out 18-20-year-olds because AEI scholar Charles Murray's UBI plan is 21+, but all others I've seen have been 18+. If it complicates things in OG-USA it could be another reason to consider dropping it - I doubt it's been used much if at all. The 0-17, 18-64, 65+ buckets are the right ones to start with IMO, and if any would be added next, it'd probably be splitting the child component into 0-5 and 6-17, to match US child allowance proposals and address differences in childcare needs by age. |
@jdebacker @MaxGhenis. I like the idea of changing the names of the variables and adding one extra:
These variables are much closer to the Tax-Calculator variable names. But I think it is important to have the " |
@jdebacker . I just noticed that all the citation references in the text of the Jupyter Book documentation were broken (see Carroll reference on this page and any of the other references), and the References page at the end of the book does not populate. You'll also notice that the OG-USA Citations page does not populate. I fixed the in-text citations and the References page by adding these two lines at the end of the
However, I still cannot get the Citations page to populate. Maybe we leave this Citations page issue to another PR. |
@rickecon I'd drop the "dol" here. When we switch this over to OG-MOD this will be confusing since some calibrations will use a different currency. Maybe some other name like "nominal"? Or just handle it in the description of the parameter in the parameters JSON file? |
@jdebacker . I like the
|
I just pinned the version of Jupyter Book to v. 0.9.1 in the Now my question is how to make it work with Jupyter Book version 0.10.0. Maybe we have to add the |
I am good with those name. Thanks for thinking about this. |
I changed the Fix attempt 1
Fix attempt 2, copying citations.md to same directory as OGUSA_references.bib
I think we should move forward with this PR as it is, and work to fix the citations page in a future PR, following the Issue #717 thread. |
@jdebacker . I have now updated the UBI variable names according to the discussion above in |
@jdebacker . I think I am done with all the fixes that will make it into this PR. This is ready for your (maybe) final review. |
@jdebacker . I don't know what I did, but the Jupyter Book v. 0.10.1 is now compiling the Citations page, with |
@rickecon This looks great. Thanks for your hard work on this substantial update! |
This PR adds UBI directly to
OG-USA
. It also updates the documentation to reflect the default specification of the model. In particular, it addsr_hh
to the documentation and includes the partially open economy as the default specification. The follow checklist gives the sections that I have gone through that I think are done.