-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fiscal updates #563
Fiscal updates #563
Conversation
… memory issues with TC object
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
=======================================
Coverage 84.43% 84.43%
=======================================
Files 47 47
Lines 6613 6613
=======================================
Hits 5584 5584
Misses 1029 1029 Continue to review full report at Codecov.
|
@rickecon This PR is ready for review. |
@jdebacker . The tests timed out on the Travis CI testing for Python 3.7. The last test to pass in the 3.7 CI unit tests was:
Right after that, the CI testing started giving Dask worker memory warnings like the following,
and the Python 3.7 testing stopped with the following message.
This is a |
@rickecon I restarted the test for 3.7. I'm not too worried about the dask issue on Travis CI. It's simple enough to try the test again for those instances when a worker runs into an issue. This is about the 3rd time this has happened to me in the last 2 weeks and I've always has success on the second attempt. If we are hitting the time limit, we can flag some additional tests to not run on Travis CI. |
This PR will make some updates to how fiscal related variables are computed in OG-USA. The following changes will be made:
D_f
.fiscal.get_D_G_path()
function.fiscal.py
(this and the above help to remove conditional statements related to the balanced budget option from the main TPI (and SS) code.