-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize time path output #880
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #880 +/- ##
=======================================
Coverage 79.98% 79.98%
=======================================
Files 18 18
Lines 4157 4157
=======================================
Hits 3325 3325
Misses 832 832
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR is ready to go. I ran the full suite of tests locally and found 3 failures:
The first two are expected to fail since I'm using a different version of SciPy than was used for the cached tax function estimates are checking against (and we know different versions produce slightly different parameter estimates). The third failure is because the PyGAM package is incompatible with more recent NumPy versions. If that project would merge PR #321 (which changes just two lines), this test would pass. |
@jdebacker. This looks great. Will you please update the version number to 0.10.8 in |
@jdebacker. BTW, I keep looking for alternatives to |
@rickecon Version bump done. Will look into the alternative to PyGAM - thanks. |
This PR standardizes the variables saved to the output dictionary from the time path solution. Previously, some variables had a dimension with length
T+S
while others had a length ofT
in the same dimension (as noted in Issue #879). This PR sets the first dimension of all time path output variables to be of lengthT
. This consistency in the length along this dimension will help users more easily use the model output.