-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a demographics module in OG-Core #896
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #896 +/- ##
==========================================
+ Coverage 80.26% 80.38% +0.11%
==========================================
Files 18 19 +1
Lines 4175 4445 +270
==========================================
+ Hits 3351 3573 +222
- Misses 824 872 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@rickecon All tests passing, including new ones. According to output from Fertility rates (look ok)Mortality rates (look ok)Immigration rates (too high at older ages)Population distribution transition (see odd uptick at 100):Original vs Fixed SS population (odd uptick at 100 more apparent here):I believe the uptick in the adjusted population distribution are a result of the high immigration rates at older ages. I will review the code that backs out these rates as residuals from the transition in the actual population distribution. |
@jdebacker. This is great. Merging. |
This PR creates a demographic module in OG-Core. Such a module exists in the various country calibration repositories, but since all of those now use the UN population data, much of the code is repeated. Thus, moving the module here will remove redundant code across these country-specific repos.
In addition to this, the PR will add the following functionality:
demographics.py
purely for filling out demographic variables over the transition path and in the SS).