Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Log root finding #904

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] Log root finding #904

wants to merge 1 commit into from

Conversation

talumbau
Copy link
Member

Put a wrapper around calls to opt.root so we can see how much time each call takes.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.81%. Comparing base (ff2eb25) to head (a5a2e02).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   80.72%   80.81%   +0.08%     
==========================================
  Files          19       19              
  Lines        4499     4503       +4     
==========================================
+ Hits         3632     3639       +7     
+ Misses        867      864       -3     
Flag Coverage Δ
unittests 80.81% <96.87%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ogcore/TPI.py 93.18% <100.00%> (+0.15%) ⬆️
ogcore/SS.py 87.83% <93.75%> (+0.25%) ⬆️

... and 9 files with indirect coverage changes

@rickecon
Copy link
Member

rickecon commented Jun 7, 2024

@talumbau @jdebacker. Closing this PR.

@rickecon rickecon closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants