Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing alternative SS solutions -- DO NOT MERGE #905

Closed
wants to merge 1 commit into from

Conversation

jdebacker
Copy link
Member

Included in this PR:

  1. A modification of SS.run_SS, which provides an argument to allow the user to specify if they would like to use the SS.SS_fsolve with opt.root to find the SS equilibrium (fsolve=True) or if they would like to use SS.SS_solver to use a bisection method to solve for the SS.
  2. Adds a script to run_examples to test the performance of these two.

@jdebacker
Copy link
Member Author

My results were as follows:

Run time with SS fsolve =  45.24485778808594
Run time with SS Solver =  78.92088389396667

Also, note that the SS solver method (which does not use a root finder in the outer loop) was the only method of the two that generated performance warnings (although not many of them). e.g.:

2024-03-01 20:46:42,941 - distributed.utils_perf - WARNING - full garbage collections took 35% CPU time recently (threshold: 10%)

These results suggest that the worry I had after talking with @talumbau today -- that using parallelization through dask inside of a root finder was causing serious performance issues -- may not be well founded.

cc @rickecon

@jdebacker jdebacker closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant