Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter plot fixes and extensions #914

Merged
merged 15 commits into from
Mar 19, 2024
Merged

Conversation

jdebacker
Copy link
Member

This PR updates the parameter_plots.py module to:

  1. Work with the 2D chi_n matrix (Issue Update plot_chi_n function #912)
  2. Allow for comparisons of alternative parameterizations in the same plot through the use of lists of parameter objects in the arguments to plotting functions
  3. Allows one to plot the ability profiles in levels or logs (Issue Allow for log scale in plots of ability types #913)
  4. Adds plots of cumulative survival rates

@jdebacker jdebacker marked this pull request as ready for review March 19, 2024 02:07
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.46%. Comparing base (5a811f6) to head (7de7a7c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
+ Coverage   73.21%   73.46%   +0.24%     
==========================================
  Files          19       19              
  Lines        4563     4613      +50     
==========================================
+ Hits         3341     3389      +48     
- Misses       1222     1224       +2     
Flag Coverage Δ
unittests 73.46% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ogcore/output_plots.py 96.51% <100.00%> (+0.02%) ⬆️
ogcore/output_tables.py 96.81% <100.00%> (+0.05%) ⬆️
ogcore/parameter_plots.py 82.41% <100.00%> (+1.55%) ⬆️
ogcore/utils.py 88.47% <100.00%> (ø)

... and 1 file with indirect coverage changes

@jdebacker jdebacker merged commit fdc00e2 into PSLmodels:master Mar 19, 2024
11 checks passed
@jdebacker jdebacker deleted the param_plots branch March 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants