-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for compatibility with Python 3.12 #969
Conversation
Remaining work:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #969 +/- ##
==========================================
- Coverage 71.08% 69.98% -1.11%
==========================================
Files 20 20
Lines 4977 4977
==========================================
- Hits 3538 3483 -55
- Misses 1439 1494 +55
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@jdebacker. The black formatting test is failing. And we should update the middle number (minor) of the version for this one (e.g., 0.12.0). And I think we should make the version requirement |
|
@jdebacker. This looks great. Thanks for making this update. Merging now. |
This PR updates test files so that the unit tests pass on Python 3.12. As noted in Issue #889, the OG-Core has run on Python 3.12 for some time. The update here ensure that we can tests against 3.12 and therefore publish packages compatible with that version of Python.
cc @rickecon