Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to plotting functions #978

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Conversation

jdebacker
Copy link
Member

This PR updates some plotting functions and tests of them to avoid deprecation warnings. Partly addresses Issue #951.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.01%. Comparing base (92f7594) to head (8966208).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
ogcore/parameter_plots.py 92.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
+ Coverage   69.98%   70.01%   +0.02%     
==========================================
  Files          20       20              
  Lines        4977     4985       +8     
==========================================
+ Hits         3483     3490       +7     
- Misses       1494     1495       +1     
Flag Coverage Δ
unittests 70.01% <95.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ogcore/output_plots.py 88.99% <100.00%> (+0.07%) ⬆️
ogcore/parameter_plots.py 78.30% <92.30%> (+0.01%) ⬆️

@jdebacker jdebacker marked this pull request as ready for review September 9, 2024 23:44
@jdebacker jdebacker requested a review from rickecon September 9, 2024 23:44
@jdebacker
Copy link
Member Author

@rickecon This PR is ready for your review. No version bump here -- just updating to avoid warnings.

@rickecon
Copy link
Member

@jdebacker. LGTM. Merging.

@rickecon rickecon merged commit 022d3b4 into PSLmodels:master Sep 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants