Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Add windows to build_and_test.py #109

Closed
wants to merge 2 commits into from

Conversation

rickecon
Copy link
Member

@rickecon rickecon commented May 9, 2024

This PR tests to see if adding windows-latest to the build_and_test.yml tests will work now that we are only testing Python 3.10 and 3.11.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.35%. Comparing base (3135391) to head (c2b142c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   75.35%   75.35%           
=======================================
  Files          11       11           
  Lines         852      852           
=======================================
  Hits          642      642           
  Misses        210      210           
Flag Coverage Δ
unittests 75.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rickecon rickecon changed the title Add windows to build_and_test.py [DO NOT MERGE] Add windows to build_and_test.py May 9, 2024
@rickecon
Copy link
Member Author

rickecon commented May 9, 2024

This is stuck on Windows again. I went through build_and_test.py, environment.yml, and setup.py to make sure they were in line with their corresponding files in OG-Core, which works on windows-latest. But these fixes do not seem to be working. I am going to let these GH Action CI run overnight. See Issue #78.

@rickecon
Copy link
Member Author

rickecon commented May 9, 2024

@jdebacker. Still doesn't work. I am closing this.

@rickecon rickecon closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants