Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to run_og_usa.py #122

Merged
merged 11 commits into from
Aug 26, 2024
Merged

Updates to run_og_usa.py #122

merged 11 commits into from
Aug 26, 2024

Conversation

jdebacker
Copy link
Member

This PR cleans up the run_og_usa.py script, making it clearer and saving output a common directory.

@jdebacker
Copy link
Member Author

Unsure of why tests were failing, but I think it may be related to an incompatibility between ParamTools and a recent version of marshmallow, as found in Tax-Calculator.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.22%. Comparing base (5e93add) to head (9ab32cc).
Report is 12 commits behind head on master.

Files Patch % Lines
ogusa/psid_data_setup.py 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   45.12%   45.22%   +0.10%     
==========================================
  Files          18       18              
  Lines        1405     1404       -1     
==========================================
+ Hits          634      635       +1     
+ Misses        771      769       -2     
Flag Coverage Δ
unittests 45.22% <90.90%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ogusa/__init__.py 100.00% <100.00%> (ø)
ogusa/calibrate.py 38.73% <ø> (+0.97%) ⬆️
ogusa/get_micro_data.py 94.02% <100.00%> (ø)
ogusa/macro_params.py 100.00% <ø> (ø)
ogusa/utils.py 85.84% <100.00%> (ø)
ogusa/psid_data_setup.py 98.78% <83.33%> (ø)

@jdebacker jdebacker requested a review from rickecon August 26, 2024 16:46
@rickecon
Copy link
Member

@jdebacker . This looks great. Merging.

@rickecon rickecon merged commit 42a4ff8 into PSLmodels:master Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants