pct_change specifies fill_method='pad'

[talumbau]

• Don't rely on default argument for fill_method as it was deprecated in Pandas 2.1.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9da4947) 73.76% compared to head (a3a16a2) 73.76%.

❗ Current head a3a16a2 differs from pull request most recent head e03c79a. Consider uploading reports for the commit e03c79a to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   73.76%   73.76%           
=======================================
  Files          24       24           
  Lines        1616     1616           
=======================================
  Hits         1192     1192           
  Misses        424      424           

Flag	Coverage Δ
unittests	73.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[talumbau]

@rickecon @jdebacker I noticed that the linting check is failing on files I didn't change. I like black as a formatter (good choice!). Do you want me to submit a PR that gets linting passing again? I saw this deprecation warning when running the example and thought it would be a good way to kick the tires. Let me know what makes sense.

[jdebacker]

@talumbau I appreciate you opening another PR to fix the formatting. We use black with the 79 character line option. If you upgrade to the most recent black version and run black -l 79 ./ from the OG-USA directory, this should resolve the linting failures.

[rickecon]

@talumbau. Yes. We just merged a PR into OG-Core (PR #898) that set the black requirement in environment.yml to black>=24.1.1. We found that black version 23 formatted differently. We also might need to restrict the Python version in OG-USA to be <3.12.

[rickecon]

@talumbau @jdebacker. The change in this PR has been added to PR #89, along with another line in the macro_params.py module that required a similar update. I am closing this PR.