Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas update #2526

Merged
merged 17 commits into from
Jan 12, 2021
Merged

Pandas update #2526

merged 17 commits into from
Jan 12, 2021

Conversation

jdebacker
Copy link
Member

@jdebacker jdebacker commented Jan 4, 2021

This PR updates the version of the Pandas dependency from >=1.1.0 to >=1.2.0 and updates the expected results to accord with the Pandas version bump (which increases the precision of pandas.read_csv).

This PR hopes to address issues raised in Issue #2525.

@jdebacker
Copy link
Member Author

Travis CI doesn't seem to be running anymore, so I'm adding a GH Action to do unit tests and code coverage to this PR.

@jdebacker
Copy link
Member Author

This PR is now ready for review, resolving all issues in Issue #2525.

In the GH Action that is added, unit tests are run, but for now the pycodestyle checks and code coverage reports are removed. There appears to be some issue with uploading reports to codecov.io, which is happening not just in this repo, but elsewhere, so I believe the issue is on their end. The coverage reports can be uncommented in this Action when that issue is fixed.

I am unsure why the pycodestyle checks fail on the GH Action, but pass locally. The errors reported in the GH Action point to issues on lines that do not exist in the sources code. These errors are the following:

=================================== FAILURES ===================================
61
______________________________ pycodestyle-check _______________________________
62
/home/runner/work/Tax-Calculator/Tax-Calculator/taxcalc/decorators.py:303:47: E261 at least two spaces before inline comment
63
/home/runner/work/Tax-Calculator/Tax-Calculator/taxcalc/decorators.py:303:80: E501 line too long (101 > 79 characters)
64

65
______________________________ pycodestyle-check _______________________________
66
/home/runner/work/Tax-Calculator/Tax-Calculator/taxcalc/tests/conftest.py:12:1: E302 expected 2 blank lines, found 1
67
/home/runner/work/Tax-Calculator/Tax-Calculator/taxcalc/tests/conftest.py:17:1: E302 expected 2 blank lines, found 1
68

69
______________________________ pycodestyle-check _______________________________
70
/home/runner/work/Tax-Calculator/Tax-Calculator/taxcalc/tests/test_calcfunctions.py:174:77: W291 trailing whitespace

@jdebacker
Copy link
Member Author

@MattHJensen Do you have the admin rights on the codecov.io account for Tax-Calculator? Might be issue there (e.g., token expired if it has been a while since you logged on).

@MattHJensen MattHJensen closed this Jan 8, 2021
@MattHJensen MattHJensen reopened this Jan 8, 2021
@MattHJensen
Copy link
Contributor

@jdebacker, I have codecov access and just updated the token. Do you want to add testing back here and see what happens?

@jdebacker
Copy link
Member Author

@MattHJensen The codecov upload still doesn't seem to be working. I had it work again yesterday over in OG-USA, and as far as I can tell, what's done here is exactly the same.

@MattHJensen
Copy link
Contributor

@jdebacker, thanks a lot for this PR. I am merging as is and will work on the codecov issue in a separate PR.

@MattHJensen MattHJensen merged commit 599b028 into PSLmodels:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants