-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pandas update #2526
Pandas update #2526
Conversation
Travis CI doesn't seem to be running anymore, so I'm adding a GH Action to do unit tests and code coverage to this PR. |
This PR is now ready for review, resolving all issues in Issue #2525. In the GH Action that is added, unit tests are run, but for now the I am unsure why the
|
@MattHJensen Do you have the admin rights on the codecov.io account for Tax-Calculator? Might be issue there (e.g., token expired if it has been a while since you logged on). |
@jdebacker, I have codecov access and just updated the token. Do you want to add testing back here and see what happens? |
@MattHJensen The codecov upload still doesn't seem to be working. I had it work again yesterday over in OG-USA, and as far as I can tell, what's done here is exactly the same. |
@jdebacker, thanks a lot for this PR. I am merging as is and will work on the codecov issue in a separate PR. |
This PR updates the version of the Pandas dependency from
>=1.1.0
to>=1.2.0
and updates the expected results to accord with the Pandas version bump (which increases the precision ofpandas.read_csv
).This PR hopes to address issues raised in Issue #2525.