Update calculation of childnum when CTC_include17 #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattHJensen
changed the title
|
@MattHJensen if you merge in the latest master branch, your tests should pass. After that, is this PR ready for review? |
Codecov Report
@@ Coverage Diff @@
## master #2644 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 14 14
Lines 2609 2609
=======================================
Hits 2571 2571
Misses 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. |
MattHJensen
changed the title
|
@jdebacker, tests passing after merging master. Thanks a lot for the work in #2646 to make that happen. This is ready for review now. |
|
LGTM. Thanks @MattHJensen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2630.
Thanks again to @JackLandry for opening the issue and to @martinholmer and @kpomerleau for your contributions to the discussion.
cc @jdebacker and @donboyd5