Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examination/methods.md and related files #16

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Add examination/methods.md and related files #16

merged 2 commits into from
Feb 26, 2024

Conversation

martinholmer
Copy link
Collaborator

This pull request adds the examination/methods.md document as well as several files in the examination/taxcalculator directory that are used to conduct the examination of the Phase 1 dataset.

Copy link
Collaborator

@donboyd5 donboyd5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @martinholmer ! Don't yet know how to do reviews properly so I'll put minor comments here:

tax_microdata_benchmarking/examination/methods.md:

  • line 50 "an" should be "a"
  • lines 50-54 simply a note - in phase 2 we likely will have a 3rd file based on puf with methods similar to taxdata, that eventually may supplant the policy engine file. not sure if any foreshadowing is needed here but just want to mention it
  • I am probably misunderstanding something - on line 17 we say we compare ACA-PTC and in 78-79 we say there's no logic to do so. Is this something we would do later on?

Other files:

  • I am confused about clp, which has a dvars file and an empty json file but I do not see reference to a clp tax expenditure. I may just be missing something.

@martinholmer
Copy link
Collaborator Author

@donboyd5, Thanks for your helpful review. I've made several changes in response to your comments.

@martinholmer martinholmer merged commit 6ad714e into PSLmodels:master Feb 26, 2024
2 checks passed
@martinholmer martinholmer deleted the examination-methods branch February 26, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants