Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hl/cbo baseline 2024 #441

Closed
wants to merge 13 commits into from
Closed

Hl/cbo baseline 2024 #441

wants to merge 13 commits into from

Conversation

huaqunTF
Copy link

No description provided.

@jdebacker jdebacker marked this pull request as ready for review March 11, 2024 17:24
jdebacker
jdebacker reviewed Mar 11, 2024
View reviewed changes
Pipfile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed from the PR

QuickNotesMDB.docx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed from the PR.

puf_data/StatMatch/doc/cpsmar16.pdf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed from the PR.

data/tu16.csv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed from the PR.

data/raw_cps.csv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed from the PR.

data/cps_raw.csv.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed from the PR.

cpsmar2016_EXTRACT_ME.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed from the PR.

taxdata/puf/finalprep.py
data = data.filter(USABLE_VARS, axis=1)
# data = data.filter(USABLE_VARS, axis=1)
# extract the variables available in original puf and required for TAG
data = data[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change to the filter and USABLE_VARS?

Copy link
Author

@huaqunTF huaqunTF Mar 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i accidentally opened the PR, meant to have a draft PR for code comparison in my forked branch. Sorry for the confusion.

@huaqunTF huaqunTF closed this Mar 11, 2024
@jdebacker
Copy link
Member

@huaqunTF Thanks for opening a PR here. Can you describe what the goal of this PR is?

FYI, @bodiyang recently updated taxdata to reflect the most recent CBO baseline in PR #439.

@huaqunTF huaqunTF deleted the hl/cbo_baseline_2024 branch March 11, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdebacker jdebacker jdebacker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huaqunTF @jdebacker @aelsibaie @JohnxMurrill