-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMM-514 : 1097- Moving back to previous page take more time #61
Conversation
@ravishanigarapu Pls add Jira ticket Id also in PR Title. |
Done |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine.
@@ -573,7 +573,8 @@ public List<BeneficiariesDTO> searhBeneficiaryByGovIdentity(String identity) | |||
} | |||
|
|||
private MBeneficiarymapping getBeneficiariesDTONew(Object[] benMapArr) { | |||
MBeneficiarymapping benMapOBJ = new MBeneficiarymapping(); | |||
MBeneficiarymapping benMapOBJ = mappingRepo.getMapping(getBigIntegerValueFromObject(benMapArr[9]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ravishanigarapu Pls add null checks for benMapArr for ensuring safe type casting.
Can you explain how this one query fixes the delay in API response? |
Hi @drtechie , Previously they were running multiple DB queries over a loop which is resulting in delay of API response(for example, if a phone number has 10 records then loop is running for each phone number for all 9 DB queries. which total results of 90 DB calls) . Now i have removed multiple queries and added a single query which does the work of those multiple queries. Hence only A single DB query is called for each phone number which reduces the api call time. |
Thanks @ravishanigarapu |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
Checklist: