Fixed RCTConvert+PSPDFDocument.m parseURL function to be able to handle custom remote sources. #416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Passing a URL to the
document
prop causes an error on iOS. The reason is how theparseURL
function handles incoming strings. If you pass a link, the function will try to find a local resource (which is not correct) and cause an error as a result.Dependencies
react-native: 0.72.12
react-native-pspdfkit: 2.9.1
PSPDFKit: 13.3.3
PSPDFKit/Core: 13.3.3
Steps to reproduce
or
Acceptance Criteria
package.json
,package-lock.json
,samples/Catalog/package.json
,samples/Catalog/yarn.lock
,samples/NativeCatalog/package.json
, andsamples/NativeCatalog/yarn.lock
(see example commit: b32b4ed).