fix: unique username field id #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user might attempt to sign in while viewing the PIN email reset page (MyAccount/EmailResetPin). Without this patch, any attempt at submitting login info through the login form popup while on said page will fail. This is because there is both a username field in the PIN email reset form and in the login form, and both share the same id. Since the log in form is referred to as the 'ajax-login' template, this patch changes the id of its username field to 'ajaxLoginUsername', so that it is unique in this scenario. To replicate: - go to /MyAccount/EmailResetPin - select 'Sign In' - fill in the form with valid credentials - notice the 'Please enter both Library Barcode and PIN / Password.' error message. Test plan: - apply this patch - repeat the steps above - notice that, instead of an error, you are logged in as normal.
Chloe070196
changed the title
|
rebase needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user might attempt to sign in while viewing the PIN email reset page (MyAccount/EmailResetPin). Without this patch, any attempt at submitting login info through the login form popup while on said page will fail.
This is because there is both a username field in the PIN email reset form and in the login form, and both share the same id. Since the log in form is referred to as the 'ajax-login' template, this patch changes the id of its username field to 'ajaxLoginUsername', so that it is unique in this scenario.
To replicate:
Test plan: